chore(semantic): update inline citation according to HTML semantic #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <[email protected]>
✅ Deploy Preview for rehype-citation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
|
cc @timlrx |
|
Hmm I get where you are coming from but it seems like pandoc and most publishing frameworks seem to just wrap it in a span tag e.g. https://quarto.org/docs/authoring/citations.html |
|
I don't have a strong opinion on this, but and I don't really know what the enforcement for these would often look like, so no preference at all :) |
|
Alright I will leave this PR hanging for a while if some others might have a stronger view. Definitely makes sense to me, but for some reason I don't see it done in most implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/cite for more information
Signed-off-by: Aaron Pham [email protected]