Add the option {generateGraph: false} #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option generateGraph (default: true) generates some graph information with every bibliography item. When dealing with large bib files (1MB in my case), this causes a crash in citeproc-js, precisely here: https://github.com/Juris-M/citeproc-js/blob/57e3584632fe44db410da1771c4b6bd69fe729f9/src/build.js#L553 The function retrieveItem makes all bib items go through JSON.stringify and JSON.parse. JSON.stringify crashes on big inputs. Therefore, it is better to use {generateGraph: false}, I don't think we loose any feature as far as rehype-citation is concerned.
✅ Deploy Preview for rehype-citation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Makes sense to me, thanks |
|
@lairez published fix as v2.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option generateGraph (default: true) generates some graph information with every bibliography item. When dealing with large bib files (1MB in my case), this causes a crash in citeproc-js, precisely here:
https://github.com/Juris-M/citeproc-js/blob/57e3584632fe44db410da1771c4b6bd69fe729f9/src/build.js#L553
The function retrieveItem makes all bib items go through JSON.stringify and JSON.parse. JSON.stringify crashes on big inputs.
Therefore, it is better to use {generateGraph: false}, I don't think we loose any feature as far as rehype-citation is concerned.