fix for future changes in code loading #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, thank you so much! I was working my way towards this, but from the look of it you knew a lot more about how to implement this than I would have. I am grateful! |
|
I'm wondering about refactoring |
|
I can see that making sense. Happy to help if there are any issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex based parsing will dissapear, instead use the
TOML functionality in Base. We could introduce a dependency
on the TOML stdlib but AFAIU that means we would need to
bump the compat of Revise to 1.6.
With this, most tests pass on JuliaLang/julia#36018 and the ones that don't does not seem related to manifest tracking.