Inserts job in existing transaction by passing pgClient instance #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This already exists via the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take at the attempt made four years ago with the PR #200.
These changes don't introduce any breaking change with the existing behavior.
Fixes #199
Description
The idea is to be able to pass a
pg.Clientinstance to be used by theexecuteSql()of the database wrapper instead of using the connection pool.For this, I created a new property
executeOptionsin theConnectionOptionsto allow us to add more options later if we need it.This new
executeOptionsproperty is optional and can totally be used by custom implementation of theDbwrapper since it was the only workaround available since then.