two party POL holder #117
two party POL holder #117
Conversation
| env.block.time, | ||
| env.contract.address.to_string(), |
There was a problem hiding this comment.
Better just pass the &env directly instead of passing 2 values from it.
| crate::msg::ExecuteMsg::Tick {}, | ||
| ) | ||
| .unwrap(); | ||
| let mock_env = mock_env(); | ||
| let msg_exp = CosmosMsg::Custom(NeutronMsg::IbcTransfer { |
There was a problem hiding this comment.
I would pick a better name, like expected_transfer_msg to make it clear what this msg is.
| // Verify caller is the clock | ||
| if info.sender != CLOCK_ADDRESS.load(deps.storage)? { | ||
| return Err(ContractError::Unauthorized {}); | ||
| } |
| for denom_split in &self.splits { | ||
| match &denom_split.split { | ||
| SplitType::Custom(config) => { | ||
| let remapped_split = config.remap_receivers_to_routers( | ||
| self.party_a_addr.to_string(), | ||
| party_a_router.to_string(), | ||
| self.party_b_addr.to_string(), | ||
| party_b_router.to_string(), | ||
| )?; | ||
| remapped_splits.push((denom_split.denom.to_string(), remapped_split)); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure whats going on here, but it looks weird.
I think a map will work better here.
| } | ||
|
|
||
| impl SplitConfig { | ||
| pub fn remap_receivers_to_routers( |
There was a problem hiding this comment.
I think a redesign is needed here, it looks very complex and long for such a simple thing, might be missing some stuff.
| pub fn pass_blocks(&mut self, n: u64) { | ||
| self.app.update_block(|mut b| b.height += n); | ||
| } |
There was a problem hiding this comment.
CW is so raw that its crazy!
| #[test] | ||
| fn test_holder_active_does_not_allow_claims() { | ||
| // unimplemented!() | ||
| } |
There was a problem hiding this comment.
You can put the #[ignore] tag, even give a reason #[ignore = "reason"], it shows it when you run cargo test
| pub fn match_caller_party(&self, caller: String) -> Result<CovenantParty, StdError> { | ||
| let a = self.clone().party_a; | ||
| let b = self.clone().party_b; | ||
| if a.addr == caller { | ||
| Ok(a) | ||
| } else if b.addr == caller { | ||
| Ok(b) | ||
| } else { | ||
| Err(StdError::generic_err("unauthorized")) | ||
| } |
There was a problem hiding this comment.
You should be able to pass &caller to the function, and then avoid the clone and make it much simpler.
| cargo test | ||
|
|
||
| lint: | ||
| cargo +nightly clippy --all-targets -- -D warnings && cargo +nightly fmt --all --check |
There was a problem hiding this comment.
You can remove +nightly here because we are not using it, and shouldn't use it actually (I think)
| docker run --rm -v "$(pwd)":/code \ | ||
| --mount type=volume,source="$(basename "$(pwd)")_cache",target=/code/target \ | ||
| --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \ | ||
| cosmwasm/workspace-optimizer-arm64:0.12.11 |
There was a problem hiding this comment.
Make sure to update optimize versions, its at 0.14 something i think.
closes #85 . blocked by #116 .