Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use bitwise OR on bool #7459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Nov 19, 2024

This has unexpected semantics and can prevent optimizations. Note that the current code still returns the correct results, so this is mostly a cosmetic change.

This has unexpected semantics and can prevent optimizations.
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (59f50f2) to head (ef5a9ce).
Report is 601 commits behind head on main.

Files with missing lines Patch % Lines
...l/src/nodes/vector_agg/function/sum_float_single.c 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7459      +/-   ##
==========================================
+ Coverage   80.06%   82.10%   +2.03%     
==========================================
  Files         190      230      +40     
  Lines       37181    43095    +5914     
  Branches     9450    10838    +1388     
==========================================
+ Hits        29770    35382    +5612     
- Misses       2997     3395     +398     
+ Partials     4414     4318      -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have test to confirm correct semantics

@akuzm
Copy link
Member Author

akuzm commented Nov 19, 2024

Can we have test to confirm correct semantics

This is tested heavily by vector_agg_functions. The results were actually correct, but I think it is error-prone and might prevent some optimizations, so I changed it to use boolean operations. A cosmetic change, basically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants