-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of chunks with no dimension slices #6816
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fixes: #6816 Fix handling of chunks with no contraints |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
-- This file and its contents are licensed under the Apache License 2.0. | ||
-- Please see the included NOTICE for copyright information and | ||
-- LICENSE-APACHE for a copy of the license. | ||
\c :TEST_DBNAME :ROLE_SUPERUSER | ||
--- Test handling of missing dimension slices | ||
CREATE TABLE dim_test(time TIMESTAMPTZ, device int); | ||
SELECT create_hypertable('dim_test', 'time', chunk_time_interval => INTERVAL '1 day'); | ||
NOTICE: adding not-null constraint to column "time" | ||
create_hypertable | ||
----------------------- | ||
(1,public,dim_test,t) | ||
(1 row) | ||
|
||
-- Create two chunks | ||
INSERT INTO dim_test values('2000-01-01 00:00:00', 1); | ||
INSERT INTO dim_test values('2020-01-01 00:00:00', 1); | ||
SELECT id AS dim_slice_id FROM _timescaledb_catalog.dimension_slice | ||
ORDER BY id DESC LIMIT 1 | ||
\gset | ||
-- Delete the dimension slice for the second chunk | ||
DELETE FROM _timescaledb_catalog.chunk_constraint WHERE dimension_slice_id = :dim_slice_id; | ||
\set ON_ERROR_STOP 0 | ||
-- Select data | ||
SELECT * FROM dim_test; | ||
ERROR: chunk _hyper_1_2_chunk has no dimension slices | ||
-- Select data using ordered append | ||
SELECT * FROM dim_test ORDER BY time; | ||
ERROR: chunk _hyper_1_2_chunk has no dimension slices | ||
\set ON_ERROR_STOP 1 | ||
DROP TABLE dim_test; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
-- This file and its contents are licensed under the Apache License 2.0. | ||
-- Please see the included NOTICE for copyright information and | ||
-- LICENSE-APACHE for a copy of the license. | ||
|
||
\c :TEST_DBNAME :ROLE_SUPERUSER | ||
|
||
--- Test handling of missing dimension slices | ||
CREATE TABLE dim_test(time TIMESTAMPTZ, device int); | ||
SELECT create_hypertable('dim_test', 'time', chunk_time_interval => INTERVAL '1 day'); | ||
|
||
-- Create two chunks | ||
INSERT INTO dim_test values('2000-01-01 00:00:00', 1); | ||
INSERT INTO dim_test values('2020-01-01 00:00:00', 1); | ||
|
||
SELECT id AS dim_slice_id FROM _timescaledb_catalog.dimension_slice | ||
ORDER BY id DESC LIMIT 1 | ||
\gset | ||
|
||
-- Delete the dimension slice for the second chunk | ||
DELETE FROM _timescaledb_catalog.chunk_constraint WHERE dimension_slice_id = :dim_slice_id; | ||
|
||
\set ON_ERROR_STOP 0 | ||
|
||
-- Select data | ||
SELECT * FROM dim_test; | ||
|
||
-- Select data using ordered append | ||
SELECT * FROM dim_test ORDER BY time; | ||
|
||
\set ON_ERROR_STOP 1 | ||
|
||
DROP TABLE dim_test; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to use
Ensure
for these cases that are not expected but we still need an internal check for release builds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was an
Ensure
initially. However,Ensure
is replaced in debug builds byAssertMacro
. So, we cash in debug builds and not error out. Therefore, I was not able to write a regression test for this case.