Use NULL in CAgg bucket function catalog table #6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnidzwetzki
force-pushed
the
cagg_catalog_refactoring_3
branch
from
5b68a6e
to
01b3632
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6682 +/- ##
==========================================
+ Coverage 80.06% 81.46% +1.39%
==========================================
Files 190 191 +1
Lines 37181 36425 -756
Branches 9450 9464 +14
==========================================
- Hits 29770 29674 -96
+ Misses 2997 2985 -12
+ Partials 4414 3766 -648 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
force-pushed
the
cagg_catalog_refactoring_3
branch
from
01b3632
to
f1b6d20
Compare
Historically, we have used an empty string for undefined values in the catalog table continuous_aggs_bucket_function. Since timescale#6624, the optional arguments can be NULL. This patch cleans up the empty strings and changes the logic to work with NULL values.
jnidzwetzki
force-pushed
the
cagg_catalog_refactoring_3
branch
from
f1b6d20
to
1f54f27
Compare
jnidzwetzki
commented
Feb 23, 2024
| /* Bucket offset */ | ||
| if (bucket_offset != NULL) | ||
| { | ||
| values[AttrNumberGetAttrOffset(Anum_continuous_aggs_bucket_function_bucket_offset)] = |
There was a problem hiding this comment.
This code path can currently not be reached since origin is always NULL. But this will change when #6382 is merged. This PR also contains the needed test coverage for this line.
akuzm
approved these changes
Feb 23, 2024
fabriziomello
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, we have used an empty string for undefined values in the catalog table continuous_aggs_bucket_function. Since #6624, the optional arguments can be NULL. This patch cleans up the empty strings and changes the logic to work with NULL values.
Disable-check: force-changelog-file