fix: correct broken serialization #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGuthrie
force-pushed
the
jg/fix-broken-serialization
branch
from
c9ebc62
to
cd2d2de
Compare
|
This should fix #811 |
Unfortunately the usage of `Internal` in function APIs throws type safety out of the window. A handful of aggregate serialization functions were incorrectly implemented, and operated on the incorrect type, resulting in incorrect data in the serialized type. Fortunately, this serialization is only used when [partial aggregation] kicks in, so is not always triggered. [partial aggregation]: https://www.postgresql.org/docs/current/xaggr.html#XAGGR-PARTIAL-AGGREGATES
JamesGuthrie
force-pushed
the
jg/fix-broken-serialization
branch
from
cd2d2de
to
d5e2dad
Compare
syvb
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the usage of
Internalin function APIs throws type safety out of the window. A handful of aggregate serialization functions were incorrectly implemented, and operated on the incorrect type, resulting in incorrect data in the serialized type.Fortunately, this serialization is only used when partial aggregation kicks in, so is not always triggered.