Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "activationRules" parameters to the plugin #11

Closed
wants to merge 1 commit into from

Conversation

achorein
Copy link
Contributor

In order to prepare plugin for the next version with "Support receiving more content types", this PR add support to customize "plist" file NSExtensionActivationRule content from app.json

Example

  "plugins": [
     [
       "expo-config-plugin-ios-share-extension", 
       {
          "activationRules": {
             "NSExtensionActivationSupportsText": true
          }
       }
     ]
  ],

@timedtext
Copy link
Owner

Hi @achorein, appreciate your work.
I noticed that there are additional changes in your patch file. Will you be submitting any other pull requests as well? What are your plans going forward?

@achorein
Copy link
Contributor Author

achorein commented Aug 26, 2023

From my point of view react-native-receive-sharing-intent works just well (especially for ios) and we can take inspiration from his work.

The patch file you mention only inject swift code from "react-native-receive-sharing-intent" in order to keep the same implementation in react native.

So an easy way to get full support of content types :

  • Update swift code as mention in the patch
  • Add a hook to receive files, with as an example ReceiveSharingIntent.ts (need to apply patch as well)
  • Add an exemple of integration (standalone, with react-navigation and Linking using share key)

i can give it a try if you want, but not really in my priorities because I have a working solution for the moment with my demo.
It's the expo module for Android that catches my attention the most since the gradle build is no longer functional on react-native-receive-sharing-intent. For the android expo plugin could start with this patch which allow react-native-receive-sharing-intent working well in expo 46.

@timedtext
Copy link
Owner

We should put it off for now. I've been busy too. If you decide to send a new PR, feel free to do so at your convenience.

@achorein
Copy link
Contributor Author

Alright,
on my side I finally managed to make android work on all versions of expo, with the corresponding demos.
keep you in touch for next PR

@crieggalder
Copy link

Hi @timedtext - any update here? Appreciate you two teaming up on this

@achorein
Copy link
Contributor Author

I'm finally working on new npm package which use a native module for android too : https://www.npmjs.com/package/expo-share-intent

@crieggalder still in beta but you can give it a try with expo 50

@timedtext I reused your code and the other PR (#12) as well, let me know if you want access to the new repo ;)

@timedtext
Copy link
Owner

Great work! @achorein congratulations!
Recently, I haven't been using this project. I will consider whether to close this project and recommend using yours, later on.

@timedtext timedtext closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants