Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wasm32-unknown-unknown build #655

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Fix wasm32-unknown-unknown build #655

merged 2 commits into from
Feb 3, 2024

Conversation

jedel1043
Copy link
Contributor

This closes #652.

This also probably requires some CI modifications to test the wasm_bindgen builds, but that can be done in a follow-up PR.

jhpratt
jhpratt reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@jhpratt jhpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage in CI is currently broken and there's no trivial way to add checking this to the powerset (which is run before each release). So don't worry about adding CI support at the moment.

time/src/offset_date_time.rs Outdated Show resolved Hide resolved
time/src/sys/local_offset_at/wasm_js.rs Outdated Show resolved Hide resolved
@jhpratt jhpratt added C-bug Category: bug in current code A-core Area: anything not otherwise covered labels Feb 2, 2024
@jhpratt
Copy link
Member

jhpratt commented Feb 2, 2024

I'll get to this in the evening and cut a release at that point.

@jhpratt jhpratt merged commit 6c2b602 into time-rs:main Feb 3, 2024
19 of 20 checks passed
@jedel1043 jedel1043 deleted the fix-wasm-bindgen-build branch February 3, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpratt jhpratt Awaiting requested review from jhpratt

Assignees
No one assigned
Labels
A-core Area: anything not otherwise covered C-bug Category: bug in current code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation error for "wasm-bindgen"
2 participants
@jedel1043 @jhpratt