Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure under 1.80.0 #696

Closed
havok4u opened this issue Jul 29, 2024 · 1 comment
Closed

Build failure under 1.80.0 #696

havok4u opened this issue Jul 29, 2024 · 1 comment
Labels
C-duplicate Category: exact duplicate C-invalid Category: no issue exists or the issue cannot be reproduced

Comments

@havok4u
Copy link

havok4u commented Jul 29, 2024

I recently upgraded to 1.80.0 from 1.79.0 and ran my program and got the following when the crates were being pulled down, during a cargo run.

error[E0282]: type annotations needed for `Box<_>`
  --> /home/xxxxx/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error

If I change back to 1.79.0 and re-run then the problem goes away.

Thanks
@abrenneke abrenneke mentioned this issue Jul 29, 2024
Closed
1 task
howardjohn added a commit to howardjohn/ztunnel that referenced this issue Jul 29, 2024
@howardjohn
Support building with rust 1.80
9002cb4 
* `time` needs update in fuzz/
  (time-rs/time#696, probably a bug), so I
updated all packages
* Fix comment that is supposed to have a newline
* Disable 2 new linters that are false positives all over the codebase
@howardjohn howardjohn mentioned this issue Jul 29, 2024
Merged
istio-testing pushed a commit to istio/ztunnel that referenced this issue Jul 29, 2024
@howardjohn
Support building with rust 1.80 (#1241)
b40c577 
* Improve XDS error diagnostics

Based on user feedback.

Before/after

dns outage
```
2024-07-29T17:10:59.111431Z     warn    xds::client:xds{id=14}  XDS client connection error: gRPC connection error:status: Unknown, message: "client error (Connect)", source: dns error: failed to lookup address information: Temporary failure in name resolution, retrying in 15s
2024-07-29T17:22:14.958433Z     warn    xds::client:xds{id=3}   XDS client connection error: gRPC connection error connecting to https://istiod.istio-system.svc:15012: status: Unknown, message: "client error (Connect)", source: dns error: failed to lookup address information: Temporary failure in name resolution (hint: is the DNS server reachable?), retrying in 80ms
```

wrong dns name
```
2024-07-29T17:22:47.910253Z     warn    xds::client:xds{id=10}  XDS client connection error: gRPC connection error:status: Unknown, message: "client error (Connect)", source: dns error: failed to lookup address information: Name or service not known, retrying in 10.24s
2024-07-29T17:22:47.910253Z     warn    xds::client:xds{id=10}  XDS client connection error: gRPC connection error connecting to https://istiodx.istio-system.svc:15012: status: Unknown, message: "client error (Connect)", source: dns error: failed to lookup address information: Name or service not known, retrying in 10.24s
```

Bad auth (ztunnel)
```
2024-07-29T17:25:29.137815Z     warn    xds::client:xds{id=11}  XDS client connection error: gRPC connection error connecting to https://istiod.istio-system.svc:15012: status: Unauthenticated, message: "authentication failure", retrying in 15s
2024-07-29T17:35:00.273104Z     warn    xds::client:xds{id=9}   XDS client connection error: gRPC connection error connecting to https://istiod.istio-system.svc:15012: status: Unauthenticated, message: "authentication failure" (hint: check the control plane logs for more information), retrying in 5.12s
```

* Support building with rust 1.80

* `time` needs update in fuzz/
  (time-rs/time#696, probably a bug), so I
updated all packages
* Fix comment that is supposed to have a newline
* Disable 2 new linters that are false positives all over the codebase
@jhpratt
Copy link
Member

jhpratt commented Jul 30, 2024

#681
#685
#689
#693
#695

@jhpratt jhpratt closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
@jhpratt jhpratt added C-duplicate Category: exact duplicate C-invalid Category: no issue exists or the issue cannot be reproduced labels Jul 30, 2024
@jonmayer jonmayer mentioned this issue Jul 30, 2024
Closed
1 task
@jhpratt jhpratt mentioned this issue Jul 31, 2024
Closed
@chenrui333 chenrui333 mentioned this issue Aug 1, 2024
Merged
@SergioBenitez SergioBenitez mentioned this issue Aug 4, 2024
Closed
4 tasks
kxxt added a commit to kxxt/archriscv-packages that referenced this issue Aug 5, 2024
@kxxt
addpatch: deltachat-rpc-server
cf18902 
- Add fix for time-rs/time#696
- Patch ring 0.16.20
@kxxt kxxt mentioned this issue Aug 5, 2024
Merged
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this issue Aug 6, 2024
@kxxt @felixonmars
addpatch: deltachat-rpc-server
e85c7ad 
- Add fix for time-rs/time#696
- Patch ring 0.16.20
@wasabii wasabii mentioned this issue Aug 13, 2024
Closed
@gusfraser gusfraser mentioned this issue Aug 13, 2024
Closed
@jaybutera jaybutera mentioned this issue Aug 14, 2024
Closed
tombriden added a commit to tombriden/pam_rssh that referenced this issue Aug 16, 2024
@tombriden
update dependencies to fix build with rust[>=1.80.0]
993156f 
required for `time` dependency: time-rs/time#696
@Spixmaster Spixmaster mentioned this issue Aug 17, 2024
Closed
kentsommer added a commit to kentsommer/nix-config that referenced this issue Aug 19, 2024
@kentsommer
switch to wezterm cask for now due to time-rs/time#696
52580a7
kentsommer added a commit to kentsommer/nix-config that referenced this issue Aug 19, 2024
@kentsommer
switch to wezterm cask for now due to time-rs/time#696
e459b7e
dbarnett added a commit to dbarnett/gg that referenced this issue Aug 21, 2024
@dbarnett
Update src-tauri's time dep to fix building on rust 1.80
52d6182 
Fixes their time-rs/time#696
@dbarnett dbarnett mentioned this issue Aug 21, 2024
Merged
gulbanana pushed a commit to gulbanana/gg that referenced this issue Aug 22, 2024
@dbarnett @gulbanana
Update src-tauri's time dep to fix building on rust 1.80
239a12a 
Fixes their time-rs/time#696
@TheraNinjaCat TheraNinjaCat mentioned this issue Aug 22, 2024
Closed
@CervEdin CervEdin mentioned this issue Aug 23, 2024
Closed
1 task
@sunaemon sunaemon mentioned this issue Aug 24, 2024
Closed
@time-rs time-rs locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-duplicate Category: exact duplicate C-invalid Category: no issue exists or the issue cannot be reproduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhpratt @havok4u