Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Promise Retainer #443

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Add Promise Retainer #443

merged 7 commits into from
Jun 4, 2024

Conversation

timcassell
Copy link
Owner

@timcassell timcassell commented Jun 4, 2024 •
edited
Loading

Resolves #423.

Deprecated Promise(<T>).Preserve() and Promise(<T>).Duplicate().

AsyncLazy benchmarks using the new API:

develop:

Method Mean Allocated
AsyncLazy 1.259 us 416 B

PR:

Method Mean Allocated
AsyncLazy 854.4 ns 368 B

@timcassell timcassell added this to the v3.1.0 milestone Jun 4, 2024
@timcassell timcassell self-assigned this Jun 4, 2024
@timcassell timcassell marked this pull request as ready for review June 4, 2024 04:09
@timcassell timcassell linked an issue Jun 4, 2024 that may be closed by this pull request
Add Promise.GetRetainer() API #423
Closed
@timcassell timcassell merged commit 1bfd757 into develop Jun 4, 2024
36 checks passed
@timcassell timcassell deleted the promise-retainer branch June 4, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timcassell timcassell

Labels
code quality enhancement New feature or request performance
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Add Promise.GetRetainer() API
1 participant
@timcassell