[10.x] Fixes GeneratorCommand not able to prevent uppercase reserved (

laravel#48667) name such as `__CLASS__` Signed-off-by: Mior Muhammad Zaki <[email protected]>
timacdonald · Oct 24, 2023 · 598b10f · 598b10f
1 parent a3480a9
commit 598b10f
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/src/Illuminate/Console/GeneratorCommand.php b/src/Illuminate/Console/GeneratorCommand.php
@@ -449,9 +449,12 @@ protected function userProviderModel()
      */
     protected function isReservedName($name)
     {
-        $name = strtolower($name);
-
-        return in_array($name, $this->reservedNames);
+        return in_array(
+            strtolower($name),
+            collect($this->reservedNames)
+                ->transform(fn ($name) => strtolower($name))
+                ->all()
+        );
     }
 
     /**

diff --git a/tests/Integration/Console/GeneratorCommandTest.php b/tests/Integration/Console/GeneratorCommandTest.php
@@ -0,0 +1,28 @@
+<?php
+
+namespace Illuminate\Tests\Integration\Console;
+
+use Orchestra\Testbench\TestCase;
+
+class GeneratorCommandTest extends TestCase
+{
+    /**
+     * @dataProvider reservedNamesDataProvider
+     */
+    public function testItCannotGenerateClassUsingReservedName($given)
+    {
+        $this->artisan('make:command', ['name' => $given])
+            ->expectsOutputToContain('The name "'.$given.'" is reserved by PHP.')
+            ->assertExitCode(0);
+    }
+
+    public static function reservedNamesDataProvider()
+    {
+        yield ['__halt_compiler'];
+        yield ['__HALT_COMPILER'];
+        yield ['array'];
+        yield ['ARRAY'];
+        yield ['__class__'];
+        yield ['__CLASS__'];
+    }
+}