Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed importing of 'utils' in 'slate.classes' so that it wouldn't clobber when users have another module called 'utils' #45

Closed
wants to merge 1 commit into from

Conversation

violet4
Copy link

@violet4 violet4 commented Oct 5, 2018

this is a better version than my previous #44, following that described by #32 (comment)

  • I kept it simple for ease of review and merging
  • my friend had a namespace clobber - slate's insert utils imported a different utils
  • the import statement from . import utils isn't compatible in all situations - out of these two situations, it usually only works in one of them: running the program which contains from . import utils directly from the command line (e.g. python classes.py) vs importing the file which contains from . import utils as a module from other python code.

my original solution was import slate.utils as utils, but I think from slate import utils as described by @mvherweg in #32 (comment) is a better solution.

…bber when users have another module called 'utils'
@violet4
Copy link
Author

violet4 commented Sep 1, 2024

considering issue #51 and my PR is from nearly 6 years ago, i'll go ahead and close this PR.

@violet4 violet4 closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant