web: add generators for typescript defs #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/web-grpc-typescript
branch
from
f69f879
to
4f5b3ac
Compare
nicks
commented
Oct 24, 2019
| @@ -0,0 +1,22 @@ | |||
| declare namespace OpenAPI2 { | |||
| export interface webviewView { | |||
| log?: string; | |||
There was a problem hiding this comment.
this is the main thing to look at
separately, we should strategize on how to substitute these generated types for the handwritten types in types.ts
There was a problem hiding this comment.
Aww, it makes all of these optional fields? Why?
There was a problem hiding this comment.
in proto3, fields can only be optional. there's some good discussion here:
protocolbuffers/protobuf#2497
https://capnproto.org/faq.html#how-do-i-make-a-field-required-like-in-protocol-buffers
nicks
force-pushed
the
nicks/web-grpc-typescript
branch
from
4f5b3ac
to
f626c75
Compare
jazzdan
reviewed
Oct 24, 2019
toast.yml
Outdated
| output_paths: | ||
| - web/src/view.d.ts | ||
| command: | | ||
| npx @manifoldco/swagger-to-ts pkg/webview/view.swagger.json --camelcase --output web/src/view.d.ts |
There was a problem hiding this comment.
If we want to continue with using yarn everywhere I think we can change this to use yarn dlx:
Suggested change
| npx @manifoldco/swagger-to-ts pkg/webview/view.swagger.json --camelcase --output web/src/view.d.ts | |
| yarn dlx @manifoldco/swagger-to-ts pkg/webview/view.swagger.json --camelcase --output web/src/view.d.ts |
nicks
force-pushed
the
nicks/web-grpc-typescript
branch
from
f626c75
to
6c1d647
Compare
jazzdan
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jazzdan,
Please review the following commits I made in branch nicks/web-grpc-typescript:
4f5b3ac (2019-10-24 18:02:06 -0400)
web: add generators for typescript defs