[kubebuilder] Remove GOARCH to make it work on the Apple Silicon（M1/M2) env #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LittleWat
changed the title
…2）env ## change - [kubebuilder] Remove GOARCH to make it work on the Apple Silicon（M1/M2）env ## test - I confirmed that this works on both the linux amd64 env and the darwin arm64 env. Signed-off-by: Kohei Watanabe <[email protected]>
nicks
reviewed
Apr 19, 2024
| @@ -36,7 +36,7 @@ def kubebuilder(DOMAIN, GROUP, VERSION, KIND, IMG='controller:latest', CONTROLLE | |||
|
|
|||
| # build to tilt_bin beause kubebuilder has a dockerignore for bin/ | |||
| def binary(): | |||
| return 'CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -o tilt_bin/manager cmd/main.go' | |||
| return 'CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -o tilt_bin/manager cmd/main.go' | |||
There was a problem hiding this comment.
hmmm...i'm not sure this is quite right. you really want this to match the arch of the cluster, not the local machine.
you might be able to get the right arch with something like
$(tilt get cluster default -o=jsonpath --template="{.status.arch}")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change
test