Add NPS Graph Widget #105
Add NPS Graph Widget #105
Conversation
* tillvit-development: (29 commits) Add playbackOptions hide flag Add fn+direction display for mac, select to start/end Remove border radius for playbackoptions Make collapse button not tabbable + move button Make collapse button not tabbable Add playback options toggle button Fix initial load for warp/fake row in playbackoptions widget Add chart details to requiresSSC Remove note from selection when deleted Reduce note layout selection opacity Fix popup y pos Fix waterfall positioning Playback options, keybind tooltip update Fix upperbound/lowerbound on reverse Fix missing app in statuswidget Add detect sync + offset to edit timing Tweak keybinds to not trigger when button selected Fix timing tracks not clearing animation on reuse Fix right timing track visiblity, note layout y calc Fix timing track visibility not moving instantly ...
|
Looked through the changes; works quite well except there are a few issues with calculating the y position of the text in CMod. There also seems to be a bug in the calculation of the last beat/second that is also present in the old NoteLayoutWidget. I pushed a fix to the y position and added Also, since both of the widgets share the same layout and overlays, we could just combine them and have each widget override the |
|
I'm not surprised to hear the cmod issues. I could tell something was probably wrong, but I couldn't work out what. And I agree, I'll take a look at building a base class for both of these widgets to extend. |
|
Did some bug fixes, will do more thorough review soon |
I recently saw someone lamenting the fact that there was no nps graph in SMEditor, so I thought I'd try adding one.
The graph includes a nps display that follows the mouse position.
I've also added preferences to show/hide the graph, and change the colors.