Fix notefield/waveform memory leaks

tillvit · Nov 17, 2024 · 580687a · 580687a
1 parent e4e9bfe
commit 580687a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app/src/chart/component/edit/Waveform.ts b/app/src/chart/component/edit/Waveform.ts
@@ -120,8 +120,10 @@ export class Waveform extends Sprite implements ChartRendererComponent {
     )
     this.trackVariable(() => this.renderer.chartManager.chartAudio.hasFilters())
 
+    const onUpdate = () => this.getData()
+
     this.anchor.set(0.5)
-    this.renderer.chartManager.chartAudio.onUpdate(() => this.getData())
+    this.renderer.chartManager.chartAudio.onUpdate(onUpdate)
     this.getData()
     this.resizeWaveform()
 
@@ -131,7 +133,7 @@ export class Waveform extends Sprite implements ChartRendererComponent {
     const audioChanged = () => {
       this.getData()
       this.resizeWaveform()
-      this.renderer.chartManager.chartAudio.onUpdate(() => this.getData())
+      this.renderer.chartManager.chartAudio.onUpdate(onUpdate)
     }
     EventHandler.on("timingModified", timingHandler)
     this.on("destroyed", () => {
@@ -140,6 +142,7 @@ export class Waveform extends Sprite implements ChartRendererComponent {
     EventHandler.on("audioLoaded", audioChanged)
     this.on("destroyed", () => {
       EventHandler.off("audioLoaded", audioChanged)
+      this.renderer.chartManager.chartAudio.offUpdate(onUpdate)
     })
   }
 

diff --git a/app/src/chart/component/notefield/NoteContainer.ts b/app/src/chart/component/notefield/NoteContainer.ts
@@ -42,7 +42,7 @@ export class NoteContainer extends Container {
     EventHandler.on("chartModified", purgeNotes)
     this.on("destroyed", () => {
       EventHandler.off("timeSigChanged", timeSig)
-      EventHandler.on("chartModified", purgeNotes)
+      EventHandler.off("chartModified", purgeNotes)
     })
   }