Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency validation #54

Closed
tillias opened this issue Oct 15, 2020 · 0 comments · Fixed by #67
Closed

Dependency validation #54

tillias opened this issue Oct 15, 2020 · 0 comments · Fixed by #67
Labels
feature-major Major feature
Milestone
Milestone 1.0.0

Comments

@tillias
Copy link
Owner

tillias commented Oct 15, 2020 •
edited
Loading

It shouldn't be possible to create dependency between same microservices twice. Also cyclic dependencies should be validated and introduction of cycles should be prohibited
@tillias tillias added this to the Version 1.0 milestone Oct 15, 2020
tillias pushed a commit that referenced this issue Oct 26, 2020
Added BE validation when creating or updating dependency #54
58af8bd 
1. For circular dependencies
2. For dependency with same source and target (self cycle)
3. For invalid situations / inputs
4. Unit tests for all the stuff
tillias pushed a commit that referenced this issue Oct 26, 2020
Exception handling refactoring #54
9170efb
tillias pushed a commit that referenced this issue Oct 26, 2020
SonarCloud bugfix #54
0b54932
tillias pushed a commit that referenced this issue Oct 26, 2020
Added docker tag #54
404644f
tillias pushed a commit that referenced this issue Oct 26, 2020
Docker tag is now env variable #54
e15c094
tillias pushed a commit that referenced this issue Oct 27, 2020
Fixed integration tests #54
c82b7a8
tillias pushed a commit that referenced this issue Oct 27, 2020
Custom exception handling for graph dependency validation errors #54
226a495 
HTTP 422, see https://softwareengineering.stackexchange.com/questions/329229/should-i-return-an-http-400-bad-request-status-if-a-parameter-is-syntactically
tillias pushed a commit that referenced this issue Oct 27, 2020
Code cleanup #54
16b06d2
@tillias tillias linked a pull request Oct 27, 2020 that will close this issue
Dependency validation #54 #67
Merged
tillias pushed a commit that referenced this issue Oct 27, 2020
Merge pull request #67 from tillias/dev
885d224 
Dependency validation #54
@tillias tillias mentioned this issue Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-major Major feature
Projects
None yet
Milestone
Milestone 1.0.0
Development

Successfully merging a pull request may close this issue.

Dependency validation #54 tillias/microservice-catalog
1 participant
@tillias