Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency graph is incorrect, missing edges #20

Closed
tillias opened this issue Oct 6, 2020 · 2 comments · Fixed by #21
Closed

Dependency graph is incorrect, missing edges #20

tillias opened this issue Oct 6, 2020 · 2 comments · Fixed by #21
Labels
bug Something isn't working
Milestone
Milestone 1.0.0

Comments

@tillias
Copy link
Owner

tillias commented Oct 6, 2020

https://microcatalog.herokuapp.com/dashboard/dependencies

1->4
2->4
3->4
@tillias tillias added the bug Something isn't working label Oct 6, 2020
@tillias
Copy link
Owner Author

tillias commented Oct 6, 2020

Try debugging with heroku db, make sure dropFirst is disabled and spring context is prod

@tillias
Copy link
Owner Author

tillias commented Oct 7, 2020

Rootcause:
There are 4 microservices:
Service1, Service2, Service3, AuthService

And 3 dependencies:
S1->AS, S2->AS, S3->AS

When graph is build, only dependencies are loaded, thus nodes DataSet doesn't include AuthService.

Solution: build nodes DataSet based on union of all sources and targets (unique by ID)

tillias pushed a commit that referenced this issue Oct 7, 2020
Bugfixing #20
b061237
@tillias tillias linked a pull request Oct 7, 2020 that will close this issue
Dev #21
Merged
@tillias tillias added this to the Version 1.0 milestone Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Milestone 1.0.0
Development

Successfully merging a pull request may close this issue.

Dev tillias/microservice-catalog
1 participant
@tillias