Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scripts pass with Standard JS code style 16.0.1 #674

Closed
36 tasks done
jiri-janousek opened this issue Nov 8, 2020 · 8 comments
Closed
36 tasks done

Make scripts pass with Standard JS code style 16.0.1 #674

jiri-janousek opened this issue Nov 8, 2020 · 8 comments
Assignees
@jiri-janousek @d-r-q @a-m-s @Romunix
Labels
type: maintenance Maintenance tasks.

Comments

@jiri-janousek
Copy link
Member

jiri-janousek commented Nov 8, 2020 •
edited
Loading

Progress

Procedure

  1. flatpak install nuvola eu.tiliado.NuvolaAdk//master
  2. alias nuvola-adk-master="flatpak run --filesystem=~/projects/nuvola-apps eu.tiliado.NuvolaAdk//master"
  3. nuvola-adk-master
  4. standard --version → 16.0.1
  5. standard --fix → this should fix most errors
  6. standard → if there are any errors left, you need to fix them manually
  7. Verify changes and push
@jiri-janousek jiri-janousek added the type: maintenance Maintenance tasks. label Nov 8, 2020
@jiri-janousek
Copy link
Member Author

jiri-janousek commented Nov 8, 2020 •
edited
Loading

Hello @a-m-s, @d-r-q and @Romunix. I've updated the master branch of Nuvola ADK with Standard JS code style checker 16.0.1. Could you look at your scripts and fix new errors? standard --fix should fix most errors. If you need any help, add a comment here. Thanks :-)

jiri-janousek added a commit to tiliado/nuvola-app-8tracks that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
c45e16f 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-amazon-cloud-player that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
14e71ce 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-apple-music that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
a84821b 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-bandcamp that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
3d75a1d 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-brain-fm that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
42f0a1f 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
ced9422 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-difm that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
e84e58d 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-focus-at-will that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
564c22a 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-gaana that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
fea17c8 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-google-calendar that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
44cb43d 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-google-keep that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
4ef5fa4 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
6e9cfd0 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-idagio that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
df4948b 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-ivoox that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
d40cf46 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-jamendo that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
3588c62 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-jango that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
6d9b67a 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-kexp that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
60ffb9c 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-mentorfm that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
6d921df 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-mixcloud that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
82fac8d 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-npr-one that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
2cbf9cd 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-owncloud-music that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
93f2dde 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-pandora that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
680a82b 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-plex that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
92ef1b2 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-pocket-casts that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
ba94438 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-primephonic that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
4782220 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-siriusxm that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
089d99b 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-soundcloud that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
518d5c8 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-spotify that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
7533a53 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-tidal that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
8663d3f 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-tunein that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
a8230a6 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-youtube that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
f77dee2 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-youtube-music that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
0c6f21e 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-pocket-casts that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
0d682db 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
8cfb80d 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Nov 8, 2020
@jiri-janousek
Apply standard --fix
1de3fb7 
Issue: tiliado/nuvolaplayer#674
@jiri-janousek
Copy link
Member Author

You can also look at fixes applied to my scripts.

@ams
Copy link

ams commented Nov 9, 2020

ams

I think you mean a different person, I have nothing to do with this project.

@d-r-q
Copy link

d-r-q commented Nov 9, 2020 •
edited
Loading

Hi, @fenryxo
I will look at it later this week

@jiri-janousek
Copy link
Member Author

ams

I think you mean a different person, I have nothing to do with this project.

Yes, you're right. @a-m-s is the correct person. Sorry for the noise.

Romunix added a commit to tiliado/nuvola-app-qobuz that referenced this issue Nov 11, 2020
@Romunix
Apply standard --fix
699ef85 
Issue: tiliado/nuvolaplayer#674
@jiri-janousek
Copy link
Member Author

Hello, @a-m-s, any chance you could manage to port your scripts before 2020-11-28? :-)

jiri-janousek added a commit to tiliado/nuvolasdk that referenced this issue Nov 16, 2020
@jiri-janousek
Apply standard --fix
38029ba 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-flatpaks that referenced this issue Dec 6, 2020
@jiri-janousek
Switch to standard 16.0.1 also for stable builds
ddff0ff 
Issue: tiliado/nuvolaplayer#674
@jiri-janousek
Copy link
Member Author

Hello, @a-m-s, any chance you could manage to port your scripts before 2020-12-27? :-)

jiri-janousek added a commit to tiliado/nuvola-app-amazon-cloud-player that referenced this issue Dec 24, 2020
@jiri-janousek
Apply standard --fix
a66d701 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-bbc-iplayer that referenced this issue Dec 24, 2020
@jiri-janousek
Apply standard --fix
b01f682 
Issue: tiliado/nuvolaplayer#674
jiri-janousek added a commit to tiliado/nuvola-app-jupiter-broadcasting that referenced this issue Dec 24, 2020
@jiri-janousek
Apply standard --fix
ad6e7ce 
Issue: tiliado/nuvolaplayer#674
@jiri-janousek
Copy link
Member Author

All green.

@jiri-janousek jiri-janousek mentioned this issue Dec 27, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiri-janousek jiri-janousek

@d-r-q d-r-q

@a-m-s a-m-s

@Romunix Romunix

Labels
type: maintenance Maintenance tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jiri-janousek @d-r-q @a-m-s @ams @Romunix