Qobuz Player integration #438
Comments
First version, 80% complete. Only seeking and volume changing are missing but I basically never use them. No fancy feature from latest API versions. Issue: tiliado/nuvolaplayer#438
First version, 80% complete. Only seeking and volume changing are missing but I basically never use them. No fancy feature from latest API versions. - Author: Hervé Cauwelier <[email protected]> - Reviewed by: FIXME <FIXME> - Issue: tiliado/nuvolaplayer#438
|
Hello @bors-ltd. Thanks for your work. Since you have a working script, you can decide on the level of cooperation:
What's your choice? |
|
Let me put that another way: I'll use it on a daily basis (I work with music), and I hope my work will be useful to others. So yes I'll maintain the script and do the remaining work for it to be published in the stable branch. It should be details only, I tried to follow the docs, and the code is already checked. The biggest issue for me is how you feel about not implementing volume change (I want my volume keys to act at the system level, not a single app), and seeking. I'd also like your opinion on the I also wanted to pause the player when headphones are unplugged but it doesn't seem to be documented. Yet? |
|
Great, so the best option is to go for stable repo - that way your work will be most useful for others :-)
Fot the stable channel, the integration of a volume bar is mandatory if there is any. However, it has nothing to do with volume keys, Nuvola does not handle them. It merely exposes the functionality for other clients, e.g. Media Player GNOME Shell extension provides a volume bar: The integration of progress bar is mandatory too unless there are relevant reasons not to do so. For example, Brain.fm and Focus@Will don't provide track length and position, so the progress bar cannot be integrated. "I hardly use it ever" is ok if you create script only for you, but not ok if you create it also for others - they might want to use it. There were users that asked specifically for the volume and progress bar integration.
I don't have a hard opinon about which way is better, they are both fine. Quering for
Indeed, this feature is not documented yet (#423). You can look at the blog post. If you would like to proceed further:
|
|
Good news, I misinterpreted the volume feature, and that shell extension is cool, I already adopted it. It will also be great to test my script. I'll do the extra work and review the procedure, but probably next week-end now. |
|
Reporting my duties:
Side question: what would the version number be for the first release? It was 1.1 in the template, I downgraded it to 1.0 and now I added features. |
I upgraded you Tiliado account to Tiliado developer account. You can now use it to activate the genuine flatpak builds of Nuvola.
I think Chromium was triggered with
Could you install the devel branch of the ADK and try with |
The first release will be 1.1 because there already is version 1.0 in metadata from the beginning. It then gets incremented to 1.1 when the release commit is made. |
|
You can now use |
|
Is the chromium window supposed to show in offscreen mode? Anyway, I couldn't seek, including trying manually by dragging the handle myself in the Qobuz app. I know the flag was taken into account: In the meantime, I tried with CEF itself and its Do we release anyway with a known bug? |
|
I tried to remove CSS classes from the seek bar to remove anything fancy, but even if CEF is showing the native input handle (it's a I also wrote the snippet below that quite reproduces the seek bar and clicking on the input or dragging the handle works just fine. :-/ My conclusion is that something in the Qobuz app is eating up the event. <html>
<body>
<div style="width: 100%; height: 55px">
<div style="
position: absolute;
left: 130px;
top: 27px;
width: 100%;
">
<progress step="0.01" min="0" max="287" value="0" style="
-webkit-appearance: none;
display: inline-block;
width: 100%;
height: 5px;
cursor: pointer;
background: #0091c5;
position: absolute;
top: 0;
left: 0;
z-index: 5;
"></progress>
<input type="range" step="0.01" min="0" max="287" value="0" style="
-webkit-appearance: none;
background: transparent;
display: block;
width: 100%;
height: 14px;
cursor: pointer;
margin: 0;
padding: 0;
position: relative;
top: -5px;
z-index: 110;
">
<p></p>
</div>
<div>
<script>
(function showInput() {
try {
var value = document.querySelector('input').value
document.querySelector('progress').value = value
document.querySelector('p').innerText = value
} catch (e) {}
setTimeout(showInput, 1000)
})()
</script>
</body>
</html> |
No, Chromium window is not supposed to show. Chromium should render to a pixbuf that is then rendered into Nuvola window.
I'll try to look at it.
No idea.
I think the ap is still useful without seeking. |
So I meant the Nuvola window? Anyway, I couldn't spot the difference between the two modes without checking the logs. |
In the windowed rendering mode (default), Chromium renders to its window and Chromium window is embedded into Nuvola window. In the offscreen rendering mode, there is no Chromium window, Chromium renders to an offscreen pixel buffer and then Nuvola renders the data to its window. There are a few differences under the hood: https://github.com/tiliado/valacef/issues/11#issuecomment-391983463 |
- Add `https://www.facebook.com/dialog/oauth*`, needed by Qobuz - Issue: #438
|
|
The seeking issue reticketed as tiliado/nuvola-app-qobuz#1 |
I was eager to stumble upon Nuvola and find a way to pause this web player from the keyboard multimedia keys. Because, as usual, Qobuz won't provide a Linux application.
This is my first time today with both Nuvola and writing a service integration, so please bear with me.
The text was updated successfully, but these errors were encountered: