Synchronise stream volume with app volume #3
Conversation
|
Hello. Thanks for your pull request. Could you reformat its description to match current draft of Contributor guidelines? Thanks! |
|
@fenryxo Updated! |
|
@forivall Code looks well for me 👍 Could you update copyright information in @eurythmia, could you review & merge this PR after the copyright info is updated? Thanks! BTW, I've created ticket tiliado/nuvolaplayer#139 as similar volume synchronization should be made also in other services. |
|
@fenryxo No problem. Just waiting for the copyright info update. |
Great. And don't forget to follow the current draft of Contributor guidelines. Thanks! |
Also clean trailing whitespace
|
@eurythmia it seems like you didn't notice that i updated the copyright info. I updated the copyright info 😄 |
|
@forivall I think there are no automatic notifications about branch updates, so it's a responsibility of the author of the pull request to say the branch is ready for review/merge ;-) |
|
my bad. 😖 |
|
@eurythmia, will you merge this pull request or should I take care of it? |
|
My bad, sorry. I will take care of this shortly (read:
|
Rdio does not update their volume slider when the stream's volume changes, since most platforms cannot change the volume externally. With pulseaudio and gtkwebkit, the volume can be changed externally, so this will update the slider position when the stream volume is changed by pulseaudio. Implementation notes: Accesses internal Rdio app data, so this may break in the future. If this stops working, it will safely degrade and not affect the rest of the integration. - Reviewed by: Jiří Janoušek <[email protected]> - Reviewed by: Aaron Cripps <[email protected]> - Issue: #2 - Pull Request: #3
Rdio does not update their volume slider when the stream's volume
changes, since most platforms cannot change the volume externally.
With pulseaudio and gtkwebkit, the volume can be changed externally,
so this will update the slider position when the stream volume is
changed by pulseaudio.
Implementation notes: Accesses internal Rdio app data, so this may
break in the future. If this stops working, it will safely degrade and
not affect the rest of the integration.