Join countries and regions to Natural Earth for min and max zoom #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Earth. * Import that and index it on wikidata ID. * When querying for OSM places, join to Natural Earth data to extract the min/max zooms. * Override the default YAML-provided min zoom with the one from Natural Earth. * Drop place layer features if they have max zoom and the tile nominal zoom is beyond that.
…m for countries. This fixes the broken test.
nvkelso
changed the title
rmarianski
approved these changes
Jun 15, 2018
| 'population': u'61792000', | ||
| 'source': u'openstreetmap.org', | ||
| 'wikidata': u'Q145', | ||
| 'wikipedia': u'de:United Kingdom', # LOL, de: |
nvkelso
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Join countries and regions in the
placeslayer to Natural Earth using commonwikidataIDs in order to get themin_labelandmax_labelproperties from the Natural Earth features and use them in the output. Where that's not available, fall back to country-specific defaults in the new files underspreadsheets/min_zoom/*.yaml. Although they're YAML files, they felt more like spreadsheets in the sense that they're static data tables rather than sets of rules.Connects to #977.