add documentation, handle 504 #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarianski
approved these changes
Jul 26, 2017
integration-test.py
Outdated
| @@ -503,9 +503,17 @@ def query_result(self, query): | |||
| params=dict(data=query)) | |||
| if r.status_code == 200: | |||
| break | |||
| if r.status_code != 429: | |||
| if r.status_code != 429 and r.status_code != 504: | |||
There was a problem hiding this comment.
Do you think it's clearer spelling it like:
if r.status_code == 200 or r.status_code not in (429, 504):
breakThere was a problem hiding this comment.
I like r.status_code not in (429, 504) - much better than testing 429, 504 separately.
There was a problem hiding this comment.
210227d is inspired by this comment. I kept 200 and 429/504 separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documents 429 handling, add handling to 504.
504 also may happen (as overpass is overloaded) and also typically is solvable by retrying.
Today it was happening with some (low) frequency and without that change test relying on public overpass were sometimes failing.