Merge pull request #363 from rwjblue/input-list

Force <input> `list` to be set as an attribute.
tildeio · Jun 7, 2015 · 29d16cf · 29d16cf
2 parents 6ee93f3 + 9d815e9
commit 29d16cf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/dom-helper/lib/prop.js b/packages/dom-helper/lib/prop.js
@@ -42,6 +42,13 @@ var badPairs = [{
   // if you set input.type = 'something-unknown'
   tagName: 'INPUT',
   propName: 'type'
+}, {
+  // Some versions of IE (IE8) throw an exception when setting
+  // `input.list = 'somestring'`:
+  // https://github.com/emberjs/ember.js/issues/10908
+  // https://github.com/emberjs/ember.js/issues/11364
+  tagName: 'INPUT',
+  propName: 'list'
 }];
 
 function isSettable(element, attrName) {

diff --git a/packages/dom-helper/tests/prop-test.js b/packages/dom-helper/tests/prop-test.js
@@ -3,11 +3,12 @@ import { normalizeProperty } from 'dom-helper/prop';
 QUnit.module('dom-helper prop');
 
 test('returns `undefined` for special element properties that are non-compliant in certain browsers', function() {
-  expect(2);
-  
+  expect(3);
+
   var badPairs = [
     { tagName: 'BUTTON', key: 'type' },
-    { tagName: 'INPUT', key: 'type' }
+    { tagName: 'INPUT', key: 'type' },
+    { tagName: 'INPUT', key: 'list' }
   ];
 
   badPairs.forEach(function(pair) {
@@ -24,4 +25,4 @@ test('returns `undefined` for special element properties that are non-compliant
     var actual = normalizeProperty(element, pair.key);
     equal(actual, undefined);
   });
-});
+});