Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and update multiple config and tools docs #211

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Add and update multiple config and tools docs #211

merged 2 commits into from
Nov 10, 2020

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Nov 10, 2020 •
edited
Loading

Signed-off-by: lilin90 [email protected]

What is changed?

This PR migrates applicable changes from https://github.com/tikv/tikv/commits/master/docs, including:

  • Add synchronous-replication.md to dev (confirmed with @BusyJay)
  • Update multiple config files by fixing format, adding new items, or removing outdated items (confirmed with multiple TiKV developers)
  • Update adopters.md to the latest version (@WT-Liu FYI.)
  • Fix all tikv ports in all versions: 21060 -> 20160, 21061 -> 20161 (confirmed with @nolouch)

Any related PRs or issues?

Which version does your change affect?

dev, 4.0, 3.0

@lilin90
Copy link
Member Author

lilin90 commented Nov 10, 2020 •
edited
Loading

@dcalvin @andylokandy PTAL

@lilin90
Fix wording
d311c9e 
Signed-off-by: lilin90 <[email protected]>
dcalvin
dcalvin approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcalvin dcalvin merged commit a2be731 into tikv:master Nov 10, 2020
@lilin90 lilin90 deleted the migrate-tikv-docs branch November 10, 2020 12:29
@TomShawn TomShawn mentioned this pull request Nov 11, 2020
Merged
9 tasks
@lilin90 lilin90 mentioned this pull request Nov 13, 2020
Merged
@CharLotteiu CharLotteiu mentioned this pull request Nov 23, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

@dcalvin dcalvin dcalvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilin90 @dcalvin @andylokandy