Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick sst_importer: download SST from external storage + key rewrite (#5581) to release-3.1 #5689

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Oct 21, 2019

What have you changed?

Cherry-pick #5581 to release-3.1.

What is the type of the changes?

Pick one of the following and delete the others:

  • New feature (a change which adds functionality)

How is the PR tested?

  • Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No?

Does this PR affect tidb-ansible?

No

Refer to a related PR or issue link (optional)

#5581

Benchmark result if necessary (optional)

Any examples? (optional)

…5581)

* sst_importer: download SST from external storage + key rewrite

Signed-off-by: kennytm <[email protected]>

* sst_importer: update kvproto; respect required range; add some logs

Signed-off-by: kennytm <[email protected]>

* sst_importer: fix clippy warning

Signed-off-by: kennytm <[email protected]>

* sst_importer: do check invalid prefix; use data_key for SST range

Signed-off-by: kennytm <[email protected]>

* sst_importer: use origin key for rewrite rules

Signed-off-by: kennytm <[email protected]>

* sst_importer: fix clippy warning

Signed-off-by: kennytm <[email protected]>

* sst_importer: make download range use post-rewrite keys; return new range

Signed-off-by: kennytm <[email protected]>
@kennytm kennytm added type/cherry-pick Type: PR - Cherry pick S: PTAL component/backup-restore Component: backup, import, external_storage labels Oct 21, 2019
@overvenus
Copy link
Member

/run-all-tests

@kennytm
Copy link
Contributor Author

kennytm commented Oct 21, 2019

/run-integration-copr-test

2 similar comments
@5kbpers
Copy link
Member

5kbpers commented Oct 22, 2019

/run-integration-copr-test

@5kbpers
Copy link
Member

5kbpers commented Oct 22, 2019

/run-integration-copr-test

@5kbpers
Copy link
Member

5kbpers commented Oct 22, 2019

/run-integration-tests

Copy link
Member

@5kbpers 5kbpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm
Copy link
Contributor Author

kennytm commented Oct 22, 2019

/run-integration-copr-test tikv=release-3.1

@zhouqiang-cl
Copy link
Contributor

@kennytm you should ignore copr-test. it not mettar

@kennytm
Copy link
Contributor Author

kennytm commented Oct 22, 2019

@zhouqiang-cl OK. Will it be fixed 😂

@overvenus overvenus merged commit 61465d9 into tikv:release-3.1 Oct 22, 2019
@overvenus overvenus removed the S: PTAL label Oct 22, 2019
@kennytm kennytm deleted the download-sst-3.1 branch October 22, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/backup-restore Component: backup, import, external_storage type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants