-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: support tls for the status server #5393
Conversation
6ec88bd
to
4b3053c
Compare
Any update? |
@rleungx Any progress on this? |
c8097b6
to
8e61637
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it would be nice if you can add a unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a unit test to verify that TLS status server actually works? The rest LGTM
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
8e61637
to
cc5411b
Compare
/merge |
/run-all-tests |
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
What have you changed?
This PR is trying to support TLS for the status server.
What is the type of the changes?
How is the PR tested?
For now, it is temporarily tested manually. I will add some tests to cover it.
Does this PR affect
tidb-ansible
?Yes
Refer to a related PR or issue link (optional)
Close #5340.
Release note
server: support TLS for the status server