Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copr: fix a wrong check in time parsing (#12740) #12748

Merged
merged 1 commit into from
Jun 2, 2022
Merged

copr: fix a wrong check in time parsing (#12740) #12748

merged 1 commit into from
Jun 2, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 2, 2022 •
edited
Loading

cherry-pick #12740 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/12748

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tikv.git pr/12748:release-6.1-da16e5eca3e4

Signed-off-by: gengliqi [email protected]

What is changed and how it works?

Issue Number: Close #12739

What's Changed:

See #12739

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note 

Fix a wrong check in datetime when the datetime has a fraction and 'Z'

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 2, 2022
@ti-srebot ti-srebot added sig/coprocessor SIG: Coprocessor size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick Type: PR - Cherry pick labels Jun 2, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 2, 2022
Merged
@ti-srebot
Copy link
Contributor Author

@gengliqi you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 2, 2022
@gengliqi
Copy link
Member

gengliqi commented Jun 2, 2022

/merge

@ti-chi-bot
Copy link
Member

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 64b82e3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2022
@ti-chi-bot ti-chi-bot merged commit 5c6018e into tikv:release-6.1 Jun 2, 2022
@breezewish breezewish deleted the release-6.1-da16e5eca3e4 branch June 3, 2022 06:22
@VelocityLight VelocityLight removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2022
joccau pushed a commit to joccau/tikv that referenced this pull request Jun 23, 2022
@ti-srebot @gengliqi @joccau
copr: fix a wrong check in time parsing (tikv#12740) (tikv#12748)
f8210e7 
close tikv#12739, ref tikv#12739, ref tikv#12740

See tikv#12739

Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Liqi Geng <[email protected]>
Signed-off-by: joccau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@breezewish breezewish breezewish approved these changes

@youjiali1995 youjiali1995 Awaiting requested review from youjiali1995

Assignees

@gengliqi gengliqi

Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/coprocessor SIG: Coprocessor size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @gengliqi @breezewish @sticnarf @VelocityLight @sre-bot