transport: discard droppable msg when channel full #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why not using send + try_send? |
|
|
||
| pub fn try_send(&self, mut t: T, mut try_times: usize) -> Result<(), Error> { | ||
| loop { | ||
| t = match self.ch.send(t) { |
There was a problem hiding this comment.
Any tests to cover the two branches?
|
PTAL |
|
LGTM PTAL @hhkbp2 |
BusyJay
changed the title
|
PTAL |
hhkbp2
reviewed
Sep 18, 2016
| @@ -41,7 +41,7 @@ use storage::mvcc::{MvccTxn, MvccReader, Error as MvccError}; | |||
| use storage::{Key, Value, KvPair}; | |||
| use std::collections::HashMap; | |||
| use mio::{self, EventLoop}; | |||
| use util::transport::SendCh; | |||
| use util::transport::{SendCh, MAX_SEND_RETRY_CNT}; | |||
There was a problem hiding this comment.
MAX_SEND_RETRY_CNT is a global constant and used everywhere when calling try_send(). Maybe it's good to make retry count an attribute of this channel, and ignore it when calling try_send().
siddontang
reviewed
Sep 18, 2016
|
|
||
| /// Try send t with default try times. | ||
| pub fn try_send(&self, t: T) -> Result<(), Error> { | ||
| self.send_with_try_times(t, MAX_SEND_RETRY_CNT) |
There was a problem hiding this comment.
I prefer send using retry count but try_send using only 1, like channel send and try_send.
|
LGTM |
disksing
reviewed
Sep 18, 2016
| @@ -23,7 +23,11 @@ const MAX_SEND_RETRY_CNT: usize = 5; | |||
| quick_error! { | |||
| #[derive(Debug)] | |||
| pub enum Error { | |||
| Other(err: Box<error::Error + Sync + Send>) { | |||
| Discard(reason: String) { | |||
| description("message is discard") | |||
| impl<T: Debug> From<NotifyError<T>> for Error { | ||
| fn from(e: NotifyError<T>) -> Error { | ||
| match e { | ||
| // ALLERT!! make cause sensitive data leak. |
|
LGTM. |
|
@siddontang PTAL |
|
LGTM |
mittalrishabh
pushed a commit
to mittalrishabh/tikv
that referenced
this pull request
Nov 22, 2024
* fix the issue that stale timestamp may be a future one Signed-off-by: you06 <[email protected]> * add regression test Signed-off-by: you06 <[email protected]> * lazy init lastTSO Signed-off-by: you06 <[email protected]> * fix panic Signed-off-by: you06 <[email protected]> * address comment Signed-off-by: you06 <[email protected]> --------- Signed-off-by: you06 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1028
@ngaut @siddontang @disksing @zhangjinpeng1987 PTAL