Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-compression-type should affect TiKV's response to TiDB #17176

Closed
ekexium opened this issue Jun 21, 2024 · 1 comment · Fixed by #17180
Closed

grpc-compression-type should affect TiKV's response to TiDB #17176

ekexium opened this issue Jun 21, 2024 · 1 comment · Fixed by #17180
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. report/customer Customers have encountered this bug. type/enhancement The issue or PR belongs to an enhancement.

Comments

@ekexium
Copy link
Contributor

ekexium commented Jun 21, 2024 •
edited
Loading

Bug Report

grpc-compression-type doesn't affect TiKV's response to TiDB.
Corresponding args may be missing here

tikv/src/server/server.rs

Line 96 in 8e1f26b

let channel_args = ChannelBuilder::new(Arc::clone(&env))

What version of TiKV are you using?

v6.5.2

What operating system and CPU are you using?

Doesn't matter

Steps to reproduce

Run one large SELECT statement. Monitor TiKV's network traffic.

What did you expect?

Compression setting works.

What did happened?

Compression doesn't work.
@ekexium ekexium added the type/bug The issue is confirmed as a bug. label Jun 21, 2024
@ekexium ekexium mentioned this issue Jun 24, 2024
Merged
9 tasks
@ekexium ekexium added severity/moderate type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. severity/moderate labels Jun 24, 2024
ti-chi-bot bot added a commit that referenced this issue Jun 24, 2024
@ekexium @ti-chi-bot
grpc: set compression args for TiKV service (#17180)
a1f05d6 
close #17176

Set compression arguments for TiKV service. The compression arguments are loaded from TiKV config.
It will affect TiKV's response to TiDB.

Signed-off-by: ekexium <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@zhangjinpeng87 zhangjinpeng87 mentioned this issue Jun 26, 2024
Merged
18 tasks
@ekexium ekexium changed the title grpc-compression-type doesn't affect TiKV's response to TiDB grpc-compression-type should affect TiKV's response to TiDB Jun 27, 2024
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this issue Jun 27, 2024
@ekexium @ti-chi-bot @3AceShowHand
grpc: set compression args for TiKV service (tikv#17180)
6cf8ba4 
close tikv#17176

Set compression arguments for TiKV service. The compression arguments are loaded from TiKV config.
It will affect TiKV's response to TiDB.

Signed-off-by: ekexium <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: 3AceShowHand <[email protected]>
@ti-chi-bot ti-chi-bot added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Jun 27, 2024
@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jun 27, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Jul 11, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 11, 2024
@ti-chi-bot @ekexium
grpc: set compression args for TiKV service (#17180) (#17263)
bd8245e 
close #17176

Set compression arguments for TiKV service. The compression arguments are loaded from TiKV config.
It will affect TiKV's response to TiDB.

Signed-off-by: ekexium <[email protected]>

Co-authored-by: ekexium <[email protected]>
This was referenced Jul 26, 2024
Merged
Merged
Merged
ti-chi-bot bot added a commit that referenced this issue Jul 26, 2024
@ti-chi-bot @ekexium @ti-chi-bot
grpc: set compression args for TiKV service (#17180) (#17313)
3ffa98d 
close #17176

Set compression arguments for TiKV service. The compression arguments are loaded from TiKV config.
It will affect TiKV's response to TiDB.

Signed-off-by: ekexium <[email protected]>

Co-authored-by: ekexium <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this issue Jul 26, 2024
@ti-chi-bot @ekexium
grpc: set compression args for TiKV service (#17180) (#17314)
46e7b78 
close #17176

Set compression arguments for TiKV service. The compression arguments are loaded from TiKV config.
It will affect TiKV's response to TiDB.

Signed-off-by: ekexium <[email protected]>

Co-authored-by: ekexium <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue Jul 29, 2024
@ti-chi-bot @ekexium
grpc: set compression args for TiKV service (#17180) (#17312)
39b4eec 
close #17176

Set compression arguments for TiKV service. The compression arguments are loaded from TiKV config.
It will affect TiKV's response to TiDB.

Signed-off-by: ekexium <[email protected]>

Co-authored-by: ekexium <[email protected]>
RidRisR pushed a commit to RidRisR/tikv that referenced this issue Aug 5, 2024
@ti-chi-bot @ekexium
@ti-chi-bot @RidRisR
grpc: set compression args for TiKV service (tikv#17180) (tikv#17313)
5b52390 
close tikv#17176

Set compression arguments for TiKV service. The compression arguments are loaded from TiKV config.
It will affect TiKV's response to TiDB.

Signed-off-by: ekexium <[email protected]>

Co-authored-by: ekexium <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: RidRisR <[email protected]>
iosmanthus pushed a commit to iosmanthus/tikv that referenced this issue Oct 17, 2024
@coocood @YangKeao
@ti-chi-bot @wshwsh12 @SpadeA-Tang @lance6716 @SeaRise @glorv @ti-chi-bot @solotzg @tonyxuqqi @crazycs520 @gengliqi @cfzjywxk @zeminzhou
cherry pick upstream release-7.5 commits for compatibility (tikv#1753)
3922ba8 
* charset: support utf8mb4_0900_ai_ci collation (tikv#15329)

close tikv#15328

Signed-off-by: Yang Keao <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* charset: implement utf8mb4_0900_bin collation (tikv#15398)

close tikv#15397

Signed-off-by: Yang Keao <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* expr: support json function member_of (tikv#15391)

close tikv#15388

Signed-off-by: wshwsh12 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* storage: avoid duplicated Instant:now (tikv#15489)

close tikv#15490

avoid duplicated Instant:now

Signed-off-by: SpadeA-Tang <[email protected]>

* coprocessor: use the deadline in kvrpcpb::Context (tikv#15564)

close tikv#15565

Signed-off-by: lance6716 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* tidb_query_datatype,collation: remove utf8mb4_0900_bin from need_restored_data (tikv#15572)

close tikv#15571

Signed-off-by: Yang Keao <[email protected]>

* expr: fix wrong result of 0 / decimal and 0 % decimal (tikv#15675)

close tikv#15631

Signed-off-by: SeaRise <[email protected]>

* coprocessor: do not treat deadline exceeded error as other error (tikv#15709)

ref tikv#15566

Signed-off-by: glorv <[email protected]>

* tidb_query_expr: fix the behavior of `field` function (tikv#15879) (tikv#15884)

close tikv#15878

Signed-off-by: Yang Keao <[email protected]>

Co-authored-by: Yang Keao <[email protected]>

* executor: omit truncating error when handling decimal multiplication in arithmetic operators (tikv#16187) (tikv#16277)

close tikv#16268, close pingcap/tidb#48332

omit truncating error when handling decimal multiplication in arithmetic operators

Signed-off-by: TONG, Zhigao <[email protected]>

Co-authored-by: TONG, Zhigao <[email protected]>
Co-authored-by: tonyxuqqi <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* *: uniform deadline exceeded error in cop response (tikv#16155) (tikv#16502)

close tikv#16154

Signed-off-by: crazycs520 <[email protected]>

* copr, json: handle u64 json correctly (tikv#16513) (tikv#16538)

close tikv#16512

Signed-off-by: Yang Keao <[email protected]>

Co-authored-by: Yang Keao <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* expr: fix the wrong decimal's result frac in some cases (tikv#16914) (tikv#16919)

close tikv#16913

Fix the wrong decimal's result frac in some cases.

Signed-off-by: gengliqi <[email protected]>

Co-authored-by: gengliqi <[email protected]>

* server: change the log level to debug for cop error response (tikv#15882) (tikv#16927)

ref tikv#15881

Change the coprocessor error response log level to DEBUG

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: cfzjywxk <[email protected]>

Co-authored-by: cfzjywxk <[email protected]>
Co-authored-by: cfzjywxk <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* expression: fix a `cast_string_to_decimal` truncate bug (tikv#16963) (tikv#16985)

close tikv#16962

fix a `cast_string_to_decimal` truncate bug

Signed-off-by: gengliqi <[email protected]>

Co-authored-by: gengliqi <[email protected]>

* expression: fix overflow panic in `conv` (tikv#16970) (tikv#16980)

close tikv#16969

fix overflow panic in `conv`

Signed-off-by: gengliqi <[email protected]>

Co-authored-by: gengliqi <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* copr: don't resize binary opaque when the type flen is unspecified (tikv#16617) (tikv#16713)

close tikv#16616

Signed-off-by: Yang Keao <[email protected]>

Co-authored-by: Yang Keao <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* grpc: set compression args for TiKV service (tikv#17180) (tikv#17263)

close tikv#17176

Set compression arguments for TiKV service. The compression arguments are loaded from TiKV config.
It will affect TiKV's response to TiDB.

Signed-off-by: ekexium <[email protected]>

Co-authored-by: ekexium <[email protected]>

Signed-off-by: Evan Zhou <[email protected]>

* fix format

Signed-off-by: Evan Zhou <[email protected]>

* build image for e2e

Signed-off-by: zeminzhou <[email protected]>

---------

Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
Signed-off-by: SeaRise <[email protected]>
Signed-off-by: glorv <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: Evan Zhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Co-authored-by: YangKeao <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: Shenghui Wu <[email protected]>
Co-authored-by: Spade  A <[email protected]>
Co-authored-by: lance6716 <[email protected]>
Co-authored-by: SeaRise <[email protected]>
Co-authored-by: glorv <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Co-authored-by: TONG, Zhigao <[email protected]>
Co-authored-by: tonyxuqqi <[email protected]>
Co-authored-by: crazycs <[email protected]>
Co-authored-by: gengliqi <[email protected]>
Co-authored-by: cfzjywxk <[email protected]>
Co-authored-by: cfzjywxk <[email protected]>
Co-authored-by: zzm <[email protected]>
Co-authored-by: zeminzhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. report/customer Customers have encountered this bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

grpc: set compression args for TiKV service ekexium/tikv
3 participants
@ekexium @seiya-annie @ti-chi-bot