Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logger case detection to fail #316

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

Hoverbear
Copy link
Contributor

Fixes #312 which was unwrapping some thread name stuff. This still does it but does it safely.

@Hoverbear Hoverbear added the Bug Recognized misbehavior. label Nov 1, 2019
@Hoverbear Hoverbear requested a review from BusyJay November 1, 2019 21:26
@Hoverbear Hoverbear self-assigned this Nov 1, 2019
BusyJay
BusyJay previously approved these changes Nov 2, 2019
Signed-off-by: Ana Hobden <[email protected]>
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hicqu hicqu merged commit a5e0f13 into tikv:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Recognized misbehavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RawNode::with_default_logger() panics on Option::unwrap()
4 participants