Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: update to fail 0.3 #261

Merged
merged 3 commits into from
Jul 16, 2019
Merged

cargo: update to fail 0.3 #261

merged 3 commits into from
Jul 16, 2019

Conversation

lucab
Copy link
Member

@lucab lucab commented Jul 15, 2019

This updates to latest fail 0.3. It also aligns feature naming to use failpoints everywhere, like the
underlying library.

@lucab
Copy link
Member Author

lucab commented Jul 15, 2019

/cc @overvenus @Hoverbear for review

Hoverbear
Hoverbear previously approved these changes Jul 15, 2019
Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the best, Luca!

overvenus
overvenus previously approved these changes Jul 16, 2019
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Cargo.toml Outdated Show resolved Hide resolved
lucab added 2 commits July 16, 2019 08:15
This aligns feature naming to use `failpoints` everywhere, like the
underlying library.
@lucab lucab dismissed stale reviews from overvenus and Hoverbear via 9c82e98 July 16, 2019 08:15
@lucab
Copy link
Member Author

lucab commented Jul 16, 2019

Amended with @BusyJay suggestion, PTAL.

@Hoverbear Hoverbear added this to the 0.6.0 milestone Jul 16, 2019
@Hoverbear Hoverbear merged commit 5ffa60e into tikv:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants