Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some clippy lints #168

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Resolve some clippy lints #168

merged 2 commits into from
Jan 29, 2019

Conversation

Hoverbear
Copy link
Contributor

Fixes #166.

@Hoverbear
Resolve some clippy lints
bd90c91 
Signed-off-by: Ana Hobden <[email protected]>
@Hoverbear Hoverbear requested review from brson and hicqu January 18, 2019 05:18
@Hoverbear Hoverbear added this to the 0.5.0 milestone Jan 18, 2019
@Hoverbear Hoverbear added the Tooling/Testing CI, benchmarking, and testing infrastucture. label Jan 18, 2019
@Hoverbear Hoverbear self-assigned this Jan 18, 2019
nrc
nrc approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brson
Copy link

brson commented Jan 25, 2019

lgtm

@brson
Copy link

brson commented Jan 25, 2019

seems like maybe @nrc doesn't count as a reviewer on this repo

ngaut
ngaut approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brson brson merged commit 3aead26 into master Jan 29, 2019
@overvenus overvenus deleted the resolve-clippy-lints branch October 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brson brson brson approved these changes

@nrc nrc nrc approved these changes

@ngaut ngaut ngaut approved these changes

@hicqu hicqu Awaiting requested review from hicqu

Assignees

@Hoverbear Hoverbear

Labels
Tooling/Testing CI, benchmarking, and testing infrastucture.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Hoverbear @brson @nrc @ngaut