Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct learner checking in handle_transfer_leader #165

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Correct learner checking in handle_transfer_leader #165

merged 1 commit into from
Jan 18, 2019

Conversation

Fullstop000
Copy link
Member

siddontang
siddontang approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fullstop000

LGTM

@Fullstop000
Copy link
Member Author

Got CI error from AppVeyor

git clone -q https://github.com/pingcap/raft-rs.git C:\projects\raft-rs
fatal: unable to access 'https://github.com/pingcap/raft-rs.git/': Could not resolve host: github.com

Is there something wrong with the server 🤔️ ? @Hoverbear

Hoverbear
Hoverbear approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch.

@Hoverbear
Copy link
Contributor

@Fullstop000 Sometimes Appveyor is lazy. 😆

@Hoverbear Hoverbear added this to the 0.5.0 milestone Jan 18, 2019
@Hoverbear Hoverbear added the Bug Recognized misbehavior. label Jan 18, 2019
@Hoverbear Hoverbear requested a review from hicqu January 18, 2019 02:23
@hicqu
Copy link
Contributor

hicqu commented Jan 18, 2019

LGTM.

@hicqu hicqu merged commit 24280e8 into tikv:master Jan 18, 2019
@Fullstop000 Fullstop000 deleted the issue_164 branch January 18, 2019 03:22
@Hoverbear
Copy link
Contributor

Thanks again for your contribution, @Fullstop000 ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear Hoverbear approved these changes

@siddontang siddontang siddontang approved these changes

@hicqu hicqu Awaiting requested review from hicqu

Assignees
No one assigned
Labels
Bug Recognized misbehavior.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Fullstop000 @Hoverbear @hicqu @siddontang