Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM]add user kv api #989

Closed
wants to merge 2 commits into from
Closed

[DNM]add user kv api #989

wants to merge 2 commits into from

Conversation

wentaoxu
Copy link

@wentaoxu wentaoxu commented Mar 13, 2018 •
edited
Loading

as title says, this used for gc
PTAL @zhangjinpeng1987 @disksing @nolouch

@wentaoxu wentaoxu added the DNM label Mar 13, 2018
@wentaoxu wentaoxu self-assigned this Mar 13, 2018
@CLAassistant
Copy link

CLAassistant commented Mar 13, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Connor1996
Connor1996 reviewed Mar 13, 2018
View reviewed changes
pd-client/client.go
@@ -53,6 +53,12 @@ type Client interface {
// The store may expire later. Caller is responsible for caching and taking care
// of store change.
GetStore(ctx context.Context, storeID uint64) (*metapb.Store, error)
// GetUserKV get the user kv from pd.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/get/gets

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

pd-client/client.go
@@ -53,6 +53,12 @@ type Client interface {
// The store may expire later. Caller is responsible for caching and taking care
// of store change.
GetStore(ctx context.Context, storeID uint64) (*metapb.Store, error)
// GetUserKV get the user kv from pd.
GetUserKV(ctx context.Context, key string) (string, error)
// PutUserKV put the user kv to pd.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/put/puts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

pd-client/client.go
GetUserKV(ctx context.Context, key string) (string, error)
// PutUserKV put the user kv to pd.
PutUserKV(ctx context.Context, key string, value string) error
// DeleteUserKV delete the user kv from pd.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/delete/deletes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

server/grpc_service.go
@@ -555,3 +555,56 @@ func (s *Server) notBootstrappedHeader() *pdpb.ResponseHeader {
Message: "cluster is not bootstrapped",
})
}

// GetUserKV get key from pd under dir 'user'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/get/gets

server/grpc_service.go
}, nil
}

// PutUserKV put key to pd under dir 'user'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/put/puts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

server/grpc_service.go
}, nil
}

// DeleteUserKV delete key from pd under dir 'user'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/delete/deletes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@zhangjinpeng87
Copy link
Member

Is it necessary to use pd store the safepoint? @wentaoxu

@wentaoxu
Copy link
Author

@zhangjinpeng1987 yes, I think it is the best now, sometimes we need to trace this value to debug some problems on gc.

@disksing
Copy link
Contributor

disksing commented May 2, 2018

Close it for no activity for a long time. Please reopen it if need.

@disksing disksing closed this May 2, 2018
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
ti-chi-bot pushed a commit that referenced this pull request Feb 15, 2023
@dependabot
build(deps): bump github.com/prometheus/client_golang from 1.11.0 to …
3a286c2 
…1.11.1 in /tools/pd-tso-bench (#5990)

ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref prometheus/client_golang#987, ref #987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit that referenced this pull request Feb 15, 2023
@dependabot
build(deps): bump github.com/prometheus/client_golang from 1.11.0 to …
e168bd6 
…1.11.1 in /tests/client (#5992)

ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot added a commit that referenced this pull request Feb 15, 2023
@dependabot @ti-chi-bot
build(deps): bump github.com/prometheus/client_golang from 1.11.0 to …
2839786 
…1.11.1 in /tests/mcs (#5993)

ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot added a commit that referenced this pull request Feb 15, 2023
@dependabot @ti-chi-bot
build(deps): bump github.com/prometheus/client_golang from 1.11.0 to …
951dbc6 
…1.11.1 in /client (#5991)

ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 left review comments

Assignees

@wentaoxu wentaoxu

Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wentaoxu @CLAassistant @zhangjinpeng87 @disksing @Connor1996 @sre-bot