Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "dep: update packages." #916

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Revert "dep: update packages." #916

merged 1 commit into from
Jan 13, 2018

Conversation

zhexuany
Copy link
Contributor

Reverts #915

Why should we revert this changes?

We need merge this PR together with tidb. Otherwise, we ran into dependencies hell.

@zhexuany
Copy link
Contributor Author

@disksing @coocood @tiancaiamao PTAL

@coocood
Copy link
Contributor

coocood commented Jan 13, 2018

LGTM

2 similar comments
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@zhexuany zhexuany merged commit 21dd621 into master Jan 13, 2018
@zhexuany zhexuany deleted the revert-915-etcd branch January 13, 2018 06:36
disksing added a commit that referenced this pull request Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants