resource_manager: add metrics to show resource group configuration (#8478) #8640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close tikv#8444 Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
dco-signoff: yes
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/M
Signed-off-by: nolouch <[email protected]>
ti-chi-bot
bot
added
size/XL
lhy1024
reviewed
Sep 23, 2024
| github.com/prometheus/client_model v0.2.0 // indirect | ||
| github.com/prometheus/common v0.26.0 // indirect | ||
| github.com/prometheus/procfs v0.6.0 // indirect | ||
| github.com/prometheus/client_golang v1.19.0 // indirect |
There was a problem hiding this comment.
Is it necessary to update their version?
There was a problem hiding this comment.
Yes, It's necessary. Because we relay the new Interface DeletePartialMatch in client_golang v1.19.
nolouch
approved these changes
Sep 23, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
lhy1024
approved these changes
Sep 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8478
What problem does this PR solve?
Issue Number: Close #8444
What is changed and how does it work?
Check List
Tests
Release note