*: individually check the scheduling halt for online unsafe recovery #8147
Conversation
Signed-off-by: JmPotato <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8147 +/- ##
==========================================
- Coverage 77.44% 77.38% -0.07%
==========================================
Files 471 471
Lines 61348 61347 -1
==========================================
- Hits 47510 47472 -38
- Misses 10278 10310 +32
- Partials 3560 3565 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -1001,6 +998,14 @@ func (o *PersistOptions) SetHaltScheduling(halt bool, source string) { | |||
| } | |||
| } | |||
|
|
|||
| // SetHaltScheduling set HaltScheduling. | |||
| func (o *PersistOptions) SetHaltScheduling(halt bool, source string) { | |||
There was a problem hiding this comment.
What will the source be if we use API to set it?
There was a problem hiding this comment.
There was a problem hiding this comment.
Do we still need SetHaltScheduling function if we have SetSchedulingAllowanceStatus?
There was a problem hiding this comment.
Currently, it's not used anymore, but I think it's okay to leave it there.
Signed-off-by: JmPotato <[email protected]>
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 4d44354
|
ti-chi-bot
bot
added
the
status/can-merge
JmPotato
added
the
needs-cherry-pick-release-8.1
|
In response to a cherrypick label: new pull request created to branch |
…8147) (#8155) ref #6493, close #8095 Individually check the scheduling halt for online unsafe recovery to avoid unexpectedly persisting the halt option in the intermediate process. Signed-off-by: JmPotato <[email protected]> Co-authored-by: JmPotato <[email protected]>
|
/cherry-pick release-7.1 |
|
/cherry-pick release-7.5 |
|
@lhy1024: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#6493, close tikv#8095 Signed-off-by: ti-chi-bot <[email protected]>
|
@lhy1024: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#6493, close tikv#8095 Signed-off-by: ti-chi-bot <[email protected]>
…8147) (#8194) ref #6493, close #8095 Individually check the scheduling halt for online unsafe recovery to avoid unexpectedly persisting the halt option in the intermediate process. Signed-off-by: JmPotato <[email protected]> Co-authored-by: JmPotato <[email protected]> Co-authored-by: lhy1024 <[email protected]>
What problem does this PR solve?
Issue Number: close #8095, ref #6493.
What is changed and how does it work?
Check List
Tests
Release note