-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: make TestEtcdClientSync
stable
#8084
Conversation
Signed-off-by: Ryan Leung <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
TestEtcdClientSync
stable
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8084 +/- ##
==========================================
+ Coverage 77.29% 77.30% +0.01%
==========================================
Files 469 469
Lines 61097 61097
==========================================
+ Hits 47225 47233 +8
+ Misses 10313 10311 -2
+ Partials 3559 3553 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c7b1e12
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #8085
What is changed and how does it work?
If we remove the member we connect to, we might see member is stopped before the response arrives.
Check List
Tests
Release note