-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: upgrade etcd to v3.4.31 #8017
*: upgrade etcd to v3.4.31 #8017
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
5da4ca9
to
fcca44b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
Signed-off-by: dongmen <[email protected]>
github.com/prometheus/client_golang v1.18.0 | ||
github.com/spf13/cobra v1.0.0 | ||
github.com/prometheus/client_golang v1.19.0 | ||
github.com/spf13/cobra v1.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/tikv/pd/actions/runs/8532798384/job/23374503402?pr=8017
ci failed because msg not contain "fail"
re.Contains(string(output), "Fail") |
It seems like after updating this library, achieved the right redirect to stderr (maybe fixed by this spf13/cobra#894)
Maybe you need to add I have supportted another pr to fix it:) root.SetErr(buf)
in
pd/tools/pd-ctl/tests/helper.go
Line 29 in ddf810b
func ExecuteCommand(root *cobra.Command, args ...string) (output []byte, err error) { |
cc @rleungx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #8021
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c4f1fe0
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8017 +/- ##
==========================================
- Coverage 73.58% 73.50% -0.09%
==========================================
Files 436 436
Lines 48525 48525
==========================================
- Hits 35709 35666 -43
- Misses 9757 9787 +30
- Partials 3059 3072 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
In response to a cherrypick label: new pull request created to branch |
ref tikv#5520, close tikv#8018 Signed-off-by: ti-chi-bot <[email protected]>
ref #5520, close #8018 Upgrade etcd to v3.4.31 to fix the etcd issue: etcd-io/etcd#15247 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]> Co-authored-by: lhy1024 <[email protected]>
What problem does this PR solve?
Issue Number: Close #8018, ref #5520
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note