-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: upgrade etcd to v3.4.30 (#7884) #7889
*: upgrade etcd to v3.4.30 (#7884) #7889
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
60db4ac
to
9d961d5
Compare
9d961d5
to
b45ff7f
Compare
Signed-off-by: JmPotato <[email protected]>
b45ff7f
to
2328bee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #7889 +/- ##
===============================================
+ Coverage 74.74% 74.80% +0.05%
===============================================
Files 411 412 +1
Lines 41732 41750 +18
===============================================
+ Hits 31194 31230 +36
+ Misses 7788 7779 -9
+ Partials 2750 2741 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
golang.org/x/time v0.1.0 | ||
golang.org/x/tools v0.6.0 | ||
google.golang.org/grpc v1.54.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep consistent with 1.59.0 in master?
https://github.com/tikv/pd/pull/7884/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, let's keep it the same as the grpc version used by etcd: https://github.com/etcd-io/etcd/blob/ff2304879e1bf1cf6c7c5669bc08f8e32296582e/go.mod#L42.
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2328bee
|
This is an automated cherry-pick of #7884
What problem does this PR solve?
Issue Number: close #7904, ref #5520.
What is changed and how does it work?
Check List
Tests
Release note