Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade etcd to v3.4.30 (#7884) #7889

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 7, 2024

This is an automated cherry-pick of #7884

What problem does this PR solve?

Issue Number: close #7904, ref #5520.

What is changed and how does it work?

Upgrade etcd to v3.4.30 and adopt the latest code changes.

Check List

Tests

  • Unit test
  • Integration test

Release note

Upgrade etcd to v3.4.30 to adopt the security patch.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Mar 7, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx March 7, 2024 03:49
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 7, 2024
@JmPotato JmPotato force-pushed the cherry-pick-7884-to-release-7.1 branch from 60db4ac to 9d961d5 Compare March 12, 2024 04:19
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 12, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 12, 2024
@JmPotato JmPotato force-pushed the cherry-pick-7884-to-release-7.1 branch from 9d961d5 to b45ff7f Compare March 12, 2024 04:45
Signed-off-by: JmPotato <[email protected]>
@JmPotato JmPotato force-pushed the cherry-pick-7884-to-release-7.1 branch from b45ff7f to 2328bee Compare March 12, 2024 04:53
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (8e97f3b) to head (2328bee).
Report is 1 commits behind head on release-7.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #7889      +/-   ##
===============================================
+ Coverage        74.74%   74.80%   +0.05%     
===============================================
  Files              411      412       +1     
  Lines            41732    41750      +18     
===============================================
+ Hits             31194    31230      +36     
+ Misses            7788     7779       -9     
+ Partials          2750     2741       -9     
Flag Coverage Δ
unittests 74.80% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2024
golang.org/x/time v0.1.0
golang.org/x/tools v0.6.0
google.golang.org/grpc v1.54.0
Copy link
Member

@HuSharp HuSharp Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 2328bee

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6ea3d29 into tikv:release-7.1 Mar 12, 2024
19 checks passed
@JmPotato JmPotato deleted the cherry-pick-7884-to-release-7.1 branch March 12, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants