client: fix the client retry error #7615
Conversation
Signed-off-by: Ryan Leung <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
ti-chi-bot
bot
added
size/XS
|
@lance6716: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| @@ -165,7 +165,7 @@ func (ci *clientInner) requestWithRetry( | |||
| addr = ci.pdAddrs[idx] | |||
| err = ci.doRequest(ctx, addr, reqInfo, headerOpts...) | |||
| if err == nil { | |||
| break | |||
| return nil | |||
There was a problem hiding this comment.
You are right. I misunderstand the error here.
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
What problem does this PR solve?
Issue Number: Close #7613.
What is changed and how does it work?
When the error is nil, it means the request is successful. It should not return an error.
Check List
Tests
Release note