Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errs: remove redundant FastGenWithCause in ZapError (#7497) #7545

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7497

What problem does this PR solve?

Issue Number: Close #7496

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    after
[2023/12/06 10:43:25.636 +08:00] [ERROR] [tso_dispatcher.go:498] ["[tso] getTS error after processing requests"] [dc-location=global] [stream-addr=http://127.0.0.1:64317] [error="[PD:client:ErrClientGetTSO]get TSO failed, rpc error: code = Unknown desc = [PD:tso:ErrGenerateTimestamp]generate timestamp failed, requested pd is not leader of cluster"]

some example

[2023/12/06 11:16:43.550 +08:00] [ERROR] [client_test.go:506] ["[pd] failed to close grpc clientConn"] [error="[PD:grpc:ErrCloseGRPCConn]close gRPC connection failed: test"] [stack="github.com/tikv/pd/tests/integrations/client_test.TestCustomTimeout\n\t/Users/jiangyongbo/github/pd/tests/integrations/client/client_test.go:506\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:1595"]
[2023/12/06 11:16:43.551 +08:00] [ERROR] [client_test.go:507] ["[tso] fetch pending tso requests error"] [error="[PD:client:ErrClientGetTSO]get TSO failed: test"] [stack="github.com/tikv/pd/tests/integrations/client_test.TestCustomTimeout\n\t/Users/jiangyongbo/github/pd/tests/integrations/client/client_test.go:507\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:1595"]
[2023/12/06 11:16:43.551 +08:00] [ERROR] [client_test.go:508] ["send heartbeat message fail"] [error="[PD:grpc:ErrGRPCSend]send request error: test"] [stack="github.com/tikv/pd/tests/integrations/client_test.TestCustomTimeout\n\t/Users/jiangyongbo/github/pd/tests/integrations/client/client_test.go:508\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:1595"]
[2023/12/06 11:16:43.551 +08:00] [ERROR] [client_test.go:509] ["watch gc safe point v2 error"] [error="[PD:client:ErrClientWatchGCSafePointV2Stream]watch gc safe point v2 stream failed: test"] [stack="github.com/tikv/pd/tests/integrations/client_test.TestCustomTimeout\n\t/Users/jiangyongbo/github/pd/tests/integrations/client/client_test.go:509\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:1595"]

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 13, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 13, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 22, 2023
@CabinfeverB
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 00bf089

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit c9c9979 into tikv:release-7.5 Dec 22, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants