client: add follower option #7465
Conversation
Signed-off-by: Cabinfever_B <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
release-note-none
client/client.go
Outdated
| @@ -211,6 +212,11 @@ func WithBuckets() GetRegionOption { | |||
| return func(op *GetRegionOp) { op.needBuckets = true } | |||
| } | |||
|
|
|||
| // AllowFollowerHandle means that client can send request to follower and let it handle this request. | |||
| func AllowFollowerHandle() GetRegionOption { | |||
There was a problem hiding this comment.
How about keeping consistent with the HTTP interface and changing it to WithAllowFollowerHandle?
There was a problem hiding this comment.
gRPC uses lower case, but HTTP uses MIME format. So I think no need to keep consistent.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7465 +/- ##
==========================================
+ Coverage 74.16% 74.25% +0.09%
==========================================
Files 451 451
Lines 49696 49698 +2
==========================================
+ Hits 36855 36905 +50
+ Misses 9521 9487 -34
+ Partials 3320 3306 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Cabinfever_B <[email protected]>
ti-chi-bot
bot
added
status/LGT2
client/option.go
Outdated
| } | ||
| } | ||
|
|
||
| // getMaxTSOBatchWaitIntervalgets the Follower Handle enable option. |
There was a problem hiding this comment.
| // getMaxTSOBatchWaitIntervalgets the Follower Handle enable option. | |
| // getMaxTSOBatchWaitInterval gets the Follower Handle enable option. |
Signed-off-by: Cabinfever_B <[email protected]>
|
/merge |
|
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 79b0ba0
|
ti-chi-bot
bot
added
the
status/can-merge
|
@CabinfeverB: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #7431
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note