Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncer: add region syncer client status #7461

Merged
merged 5 commits into from
Nov 30, 2023
Merged

syncer: add region syncer client status #7461

merged 5 commits into from
Nov 30, 2023

Conversation

CabinfeverB
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7431

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 28, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and nolouch November 28, 2023 06:31
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2023
@CabinfeverB CabinfeverB requested review from lhy1024 and rleungx and removed request for disksing November 28, 2023 06:34
@CabinfeverB
add test
786e6d7 
Signed-off-by: Cabinfever_B <[email protected]>

add test

Signed-off-by: Cabinfever_B <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #7461 (73064fc) into master (beedacb) will decrease coverage by 0.16%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 73064fc differs from pull request most recent head 422ab81. Consider uploading reports for the commit 422ab81 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7461      +/-   ##
==========================================
- Coverage   74.31%   74.15%   -0.16%     
==========================================
  Files         451      451              
  Lines       49757    49701      -56     
==========================================
- Hits        36977    36858     -119     
- Misses       9456     9520      +64     
+ Partials     3324     3323       -1
Flag Coverage Δ
unittests 74.15% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx
rleungx reviewed Nov 28, 2023
View reviewed changes
pkg/syncer/client.go Outdated
@@ -77,6 +79,11 @@ func (s *RegionSyncer) syncRegion(ctx context.Context, conn *grpc.ClientConn) (C

var regionGuide = core.GenerateRegionGuideFunc(false)

// IsRunningAsClient returns whether the region syncer client is running.
func (s *RegionSyncer) IsRunningAsClient() bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsRunning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the server and client share a structure, this function only represents the state of the client, and the name IsRunning may be ambiguous

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. We won't provide IsRunningAsServer.

pkg/syncer/client.go Outdated Show resolved Hide resolved
@CabinfeverB
address comment
73064fc 
Signed-off-by: Cabinfever_B <[email protected]>
@CabinfeverB
address comment
896abe1 
Signed-off-by: Cabinfever_B <[email protected]>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2023
@nolouch
Copy link
Contributor

nolouch commented Nov 30, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 896abe1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@CabinfeverB: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 5aacd66 into tikv:master Nov 30, 2023
22 checks passed
@CabinfeverB CabinfeverB mentioned this pull request Dec 28, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@nolouch nolouch nolouch approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CabinfeverB @nolouch @rleungx