Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication_mode: use placement to determin canSync and hasMajority #7202

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

disksing
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #7201

What is changed and how does it work?

  • determine canSync and hasMajority flags based on placement rule configuration.

Check List

Tests

  • Unit test

Code changes

  • Has the configuration change
    primary-replicas and dr-replicas configurations are not deprecated.

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@disksing disksing added type/bugfix This PR fixes a bug. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Oct 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 13, 2023
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #7202 (474b2aa) into master (2ba7ed4) will decrease coverage by 0.05%.
Report is 3 commits behind head on master.
The diff coverage is 74.12%.

@@            Coverage Diff             @@
##           master    #7202      +/-   ##
==========================================
- Coverage   74.58%   74.54%   -0.05%     
==========================================
  Files         442      442              
  Lines       47681    47744      +63     
==========================================
+ Hits        35565    35589      +24     
- Misses       8990     9008      +18     
- Partials     3126     3147      +21     
Flag Coverage Δ
unittests 74.54% <74.12%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@CabinfeverB
Copy link
Member

/run-check-issue-triage-complete

@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 474b2aa

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4176c1d into tikv:master Oct 16, 2023
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7209.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 16, 2023
@disksing disksing deleted the disksing/placement-cansync branch October 16, 2023 06:28
ti-chi-bot bot pushed a commit that referenced this pull request Oct 16, 2023
disksing added a commit to oh-my-tidb/pd that referenced this pull request Oct 30, 2023
disksing added a commit that referenced this pull request Oct 30, 2023
@lhy1024 lhy1024 added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 8, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #7202 on top of branch "release-7.5":

failed to git commit: exit status 1

@disksing disksing added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7783.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 1, 2024
disksing added a commit to oh-my-tidb/pd that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dr-autosync: canSync and hasMajority can be calculated wrong when placement rule config is complex
5 participants