-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replication_mode: use placement to determin canSync and hasMajority #7202
replication_mode: use placement to determin canSync and hasMajority #7202
Conversation
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
fix tikv#7201 Signed-off-by: disksing <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #7202 +/- ##
==========================================
- Coverage 74.58% 74.54% -0.05%
==========================================
Files 442 442
Lines 47681 47744 +63
==========================================
+ Hits 35565 35589 +24
- Misses 8990 9008 +18
- Partials 3126 3147 +21
Flags with carried forward coverage won't be shown. Click here to find out more. |
/run-check-issue-triage-complete |
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 474b2aa
|
In response to a cherrypick label: new pull request created to branch |
close tikv#7201 Signed-off-by: ti-chi-bot <[email protected]>
…7202) (#7209) close #7201 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: disksing <[email protected]> Co-authored-by: disksing <[email protected]>
…ikv#7202) (tikv#7209) close tikv#7201 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: disksing <[email protected]> Co-authored-by: disksing <[email protected]>
…7202) (#7209) (#7285) Co-authored-by: Ti Chi Robot <[email protected]>
In response to a cherrypick label: failed to apply #7202 on top of branch "release-7.5":
|
In response to a cherrypick label: new pull request created to branch |
close tikv#7201 Signed-off-by: ti-chi-bot <[email protected]>
…ikv#7202) (tikv#7209) close tikv#7201 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: disksing <[email protected]> Co-authored-by: disksing <[email protected]>
What problem does this PR solve?
Issue Number: Close #7201
What is changed and how does it work?
canSync
andhasMajority
flags based on placement rule configuration.Check List
Tests
Code changes
primary-replicas
anddr-replicas
configurations are not deprecated.Related changes
Release note