Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dr-autosync: move state replicate to different goroutine #6874

Merged
merged 2 commits into from
Aug 2, 2023
Merged

dr-autosync: move state replicate to different goroutine #6874

merged 2 commits into from
Aug 2, 2023

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Aug 1, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Fix #6883

What is changed and how does it work?

when backup cluster is disconnected, because that PD cannot replicate state to PD that is in backup cluster, the state change is too slow (because it needs to wait I/O timeout)

move state change to different goroutine.

Check List

Tests

  • Unit test

Related changes

Release note

None.

disksing added 2 commits August 1, 2023 17:16
@disksing
dr autosync: speed up state change
106dfb3 
Signed-off-by: disksing <[email protected]>
@disksing
fix build
05cf573 
Signed-off-by: disksing <[email protected]>
@disksing disksing requested review from nolouch, lhy1024 and rleungx August 1, 2023 09:23
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2023
nolouch
nolouch approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2023
@disksing
Copy link
Contributor Author

disksing commented Aug 2, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 05cf573

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit d65d309 into tikv:master Aug 2, 2023
@disksing disksing deleted the dr-replicate-2 branch August 2, 2023 08:20
@disksing disksing mentioned this pull request Aug 2, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Aug 2, 2023
@disksing
dr-autosync: move state replicate to different goroutine (#6874) (#6705)
198860d 
fix #6883

Signed-off-by: disksing <[email protected]>
disksing added a commit to oh-my-tidb/pd that referenced this pull request Feb 1, 2024
@disksing
dr-autosync: move state replicate to different goroutine (tikv#6874) (t…
318ec49 
…ikv#6705)

fix tikv#6883

Signed-off-by: disksing <[email protected]>
@disksing disksing mentioned this pull request Feb 1, 2024
Merged
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7824.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 18, 2024
@disksing @ti-chi-bot
This is an automated cherry-pick of tikv#6874
5cc7fae 
ref tikv#4399

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch nolouch approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dr-autosync: speed up state change
4 participants
@disksing @ti-chi-bot @nolouch @lhy1024